fix(apps): drop duplicate keycloak-client secret (chart owns it)

The forteapp chart renders Secret/keycloak-client-forte-drop from auth.registration values (verified: the live secret is tracked by the forte-drop Application and carries the correct drop.forteapps.net redirect). The overlay copy gives the secret two owners — enterprise-apps and forte-drop self-heal against each other in a sync loop (the Slack spam). Remove the overlay copy; the chart is the single source.
2026-06-05 12:55:45 +02:00
11 changed files with 15 additions and 88 deletions
@@ -23,7 +23,7 @@ jobs:
      REVIEW__INLINE_COMMENT_FALLBACK: "false"
      # LLM configuration
      LLM__PROVIDER: CLAUDE
-      LLM__META__MODEL: claude-3-opus
+      LLM__META__MODEL: claude-sonnet-4-20250514
      LLM__META__MAX_TOKENS: "4096"
      LLM__HTTP_CLIENT__API_URL: https://api.anthropic.com
      LLM__HTTP_CLIENT__API_TOKEN: ${{ secrets.ANTHROPIC_API_KEY }}
@@ -36,9 +36,6 @@ jobs:
        fetch-depth: 0
        token: ${{ secrets.AI_REVIEW_TOKEN }}

-    - name: Update submodules to remote
-      run: git submodule update --remote --merge
-
    - name: Run inline review
      uses: docker://nikitafilonov/ai-review:v0.64.0
      with:
@@ -1,20 +0,0 @@
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-
-jobs:
-  test:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
-      with:
-        fetch-depth: 0
-    - name: Install TruffleHog
-      run: |
-        curl -sSfL https://raw.githubusercontent.com/trufflesecurity/trufflehog/main/scripts/install.sh \
-          | sh -s -- -b /usr/local/bin
-    - name: Secret Scanning
-      run: trufflehog git file://. --fail --no-update --results=verified,unknown
@@ -1,5 +1,3 @@
 [submodule "shared-prompts"]
 	path = shared-prompts
 	url = https://git.forteapps.net/Forte/ai-review-prompts.git
-	branch = main
-
@@ -5,9 +5,9 @@ metadata:
  namespace: argocd
  annotations:
    argocd.argoproj.io/sync-wave: "1"
-#    notifications.argoproj.io/subscribe.on-sync-succeeded.slack: ""
-#    notifications.argoproj.io/subscribe.on-sync-failed.slack: ""
-#    notifications.argoproj.io/subscribe.on-degraded.slack: ""
+    notifications.argoproj.io/subscribe.on-sync-succeeded.slack: ""
+    notifications.argoproj.io/subscribe.on-sync-failed.slack: ""
+    notifications.argoproj.io/subscribe.on-degraded.slack: ""
  labels:
    app.kubernetes.io/name: forte-drop
    app.kubernetes.io/part-of: apps
@@ -1,33 +0,0 @@
-apiVersion: v1
-kind: Secret
-metadata:
-  name: keycloak-client-forte-drop
-  namespace: forte-drop
-  labels:
-    keycloak.forteapps.net/client-config: "true"
-  annotations:
-    keycloak.forteapps.net/source-namespace: "forte-drop"
-stringData:
-  client.json: |
-    {
-      "clientId": "forte-drop",
-      "name": "Forte Drop (web)",
-      "enabled": true,
-      "protocol": "openid-connect",
-      "clientAuthenticatorType": "client-secret",
-      "standardFlowEnabled": true,
-      "directAccessGrantsEnabled": false,
-      "serviceAccountsEnabled": false,
-      "publicClient": false,
-      "redirectUris": ["https://drop.forteapps.net/auth/callback"],
-      "webOrigins": ["https://drop.forteapps.net"],
-      "defaultClientScopes": ["openid","email","profile"],
-      "secret": {
-        "namespace": "forte-drop",
-        "name": "forte-drop-oidc-credentials",
-        "keys": {
-          "clientId": "client-id",
-          "clientSecret": "client-secret"
-        }
-      }
-    }
@@ -2,6 +2,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
 - forte-drop.yaml
- keycloak-client-forte-drop.yaml
 - forte-drop-pdb.yaml
 - forte-drop-secrets-sealed.yaml
@@ -24,15 +24,8 @@ spec:
            name: azuredns-config
            key: client-secret
      selector:
-        # NOTE: cert-manager solver selectors are NOT TLS-style wildcards. selector.dnsNames
-        # matches by exact FQDN, so '*.forteapps.net' here would match only a cert literally
-        # named '*.forteapps.net' — it would NOT cover 'drop.forteapps.net'. selector.dnsZones
-        # instead suffix-matches the zone apex AND every subdomain at any depth, so this single
-        # entry routes all forteapps.net ACME challenges (forteapps.net, *.forteapps.net,
-        # drop.forteapps.net, *.drop.forteapps.net, mcp.drop.forteapps.net, ...) through this
-        # Azure dns01 solver. Wildcard names require dns01; non-wildcard names that ever fail
-        # to match fall through to the http01 solver below.
-        dnsZones:
+        dnsNames:
+        - '*.forteapps.net'
        - 'forteapps.net'
    # HTTP-01 fallback for non-wildcard certificates
    - http01:
@@ -65,15 +58,8 @@ spec:
            name: azuredns-config
            key: client-secret
      selector:
-        # NOTE: cert-manager solver selectors are NOT TLS-style wildcards. selector.dnsNames
-        # matches by exact FQDN, so '*.forteapps.net' here would match only a cert literally
-        # named '*.forteapps.net' — it would NOT cover 'drop.forteapps.net'. selector.dnsZones
-        # instead suffix-matches the zone apex AND every subdomain at any depth, so this single
-        # entry routes all forteapps.net ACME challenges (forteapps.net, *.forteapps.net,
-        # drop.forteapps.net, *.drop.forteapps.net, mcp.drop.forteapps.net, ...) through this
-        # Azure dns01 solver. Wildcard names require dns01; non-wildcard names that ever fail
-        # to match fall through to the http01 solver below.
-        dnsZones:
+        dnsNames:
+        - '*.forteapps.net'
        - 'forteapps.net'
    # HTTP-01 fallback for non-wildcard certificates
    - http01:
@@ -233,10 +233,6 @@ spec:
              value: "{{ regex_replace_all('https?://[^/]*', request.object.metadata.annotations.\"policies.forteapps.io/auth-oidc-callback-path\", '') }}"
            - name: AUTH_OIDC_SCOPES
              value: "{{ request.object.metadata.annotations.\"policies.forteapps.io/auth-oidc-scopes\" || 'openid,profile,email'  }}"
-            - name: AUTH_OIDC_COOKIE_DOMAIN
-              value: "{{ request.object.metadata.annotations.\"policies.forteapps.io/auth-oidc-cookie-domain\" || '' }}"
-            - name: AUTH_OIDC_ALLOWED_RETURN_HOSTS
-              value: "{{ request.object.metadata.annotations.\"policies.forteapps.io/auth-oidc-allowed-return-hosts\" || '' }}"
            - name: AUTH_PUBLIC_PATHS
              value: "{{ request.object.metadata.annotations.\"policies.forteapps.io/auth-public-paths\" || '/healthz' }}"
            - name: AUTH_OIDC_COOKIE_SECRET
@@ -1326,7 +1326,7 @@ storage:
 - Shared configuration and prompts live in the `shared-prompts` Git submodule (→ `Forte/ai-review-prompts`)
 - Review mode: `ONLY_ADDED_WITH_CONTEXT` — reviews only new/changed lines plus surrounding context (token-efficient)
 - Agent mode: disabled (one-shot review, no multi-turn reasoning)
- LLM: Claude Sonnet (`claude-3-opus`)
+- LLM: Claude Sonnet (`claude-sonnet-4-20250514`)

 **Shared Prompts Structure** (submodule: `Forte/ai-review-prompts`):
 ```
@@ -1344,7 +1344,7 @@ shared-prompts/
 ```yaml
 llm:
  provider: CLAUDE
-  model: claude-3-opus
+  model: claude-sonnet-4-20250514
 vcs:
  provider: GITEA
 review:
@@ -17,7 +17,7 @@ spec:
  sources:
  - repoURL: https://dl.gitea.com/charts
    chart: gitea
-    targetRevision: "12.6.0"
+    targetRevision: "12.5.0"
    helm:
      releaseName: gitea
      valueFiles:
@@ -59,6 +59,10 @@ config:
        href: https://benken.hackathon.forteapps.net
        description: Teknisk kompetanse fra offentlige anbud
        icon: forte
+    - Forte Drop:
+        href: https://drop.forteapps.net
+        description: Self-hosted HTML-drops + MCP for Claude
+        icon: forte
    - Forte Feedback:
        href: https://feedback.forteapps.net
        description: Fortes internal feedback app