All checks were successful
AI Code Review / ai-review (pull_request) Successful in 1m40s
Codex review: the apps overlay applies namespaced resources (keycloak-client Secrets, forte-drop-secrets, PDB) to forte-drop, but no base created the namespace — first sync on a fresh cluster raced ahead of the Applications' CreateNamespace and failed with 'namespaces forte-drop not found' until a retry. Add an explicit Namespace at sync-wave -1 so it exists before the wave-0 namespaced resources (covers both web + mcp bases via the shared parent). Prune=false keeps removing a base from cascade- deleting the namespace + postgres data + the other deployment.
18 lines
785 B
YAML
18 lines
785 B
YAML
# Owns the forte-drop namespace shared by the web + mcp deployments and the
|
|
# postgres StatefulSet (infra overlay). sync-wave -1 ensures the namespace exists
|
|
# before the namespaced Secrets/PDB in this base apply (avoids a first-sync
|
|
# "namespaces forte-drop not found" race when the business-apps parent syncs).
|
|
# Prune=false so removing this base never cascade-deletes the namespace (and with
|
|
# it postgres data + the mcp deployment) — matches the earlier decision to keep
|
|
# namespace ownership decoupled from any single workload.
|
|
apiVersion: v1
|
|
kind: Namespace
|
|
metadata:
|
|
name: forte-drop
|
|
annotations:
|
|
argocd.argoproj.io/sync-wave: "-1"
|
|
argocd.argoproj.io/sync-options: Prune=false
|
|
labels:
|
|
app.kubernetes.io/managed-by: argocd
|
|
app.kubernetes.io/part-of: apps
|