gitea_admin
  • Joined on 2026-04-08
gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:26 +00:00
feature/tofu

Hardcoded CIDR range should be configurable via variable to support different network architectures.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Missing validation for domain variable - should ensure it's a valid FQDN.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Missing validation for domain variable - should ensure it's a valid FQDN.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Missing validation for domain variable - should ensure it's a valid FQDN.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Output value should be wrapped in quotes for consistency with Terraform string outputs.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Output value should be wrapped in quotes for consistency with Terraform string outputs.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Output value should be wrapped in quotes for consistency with Terraform string outputs.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Output value should be wrapped in quotes for consistency with Terraform string outputs.

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review

gitea_admin commented on pull request Forte/launchpad#15 2026-04-28 06:52:25 +00:00
feature/tofu

Inline review