feature/tofu #15

Merged
danijel.simeunovic merged 6 commits from feature/tofu into main 2026-05-29 15:48:29 +00:00

@thomas.solbjor her er "import" av tofu fra ditt repo med justeringer for å tilpasse patterns her. Også minimalisert til å kun opprette cluster, ingen managed services som postgres etc. Ta en titt.

@thomas.solbjor her er "import" av tofu fra ditt repo med justeringer for å tilpasse patterns her. Også minimalisert til å kun opprette cluster, ingen managed services som postgres etc. Ta en titt.
Ghost added the ai-review label 2026-04-28 06:51:52 +00:00
Ghost added 3 commits 2026-04-28 06:51:53 +00:00
strip cluster bootstraps
All checks were successful
AI Code Review / ai-review (pull_request) Successful in 59s
96dde22884
gitea_admin reviewed 2026-04-28 06:52:06 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -17,2 +17,3 @@
bash.exe.stackdump
bash.exe.stackdump
Owner

Empty line with trailing space should be cleaned up.

#ai-review-inline

Empty line with trailing space should be cleaned up. #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:06 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +21,4 @@
}
output "kubeconfig" {
value = module.cluster.kubeconfig
Owner

Kubeconfig should not be exposed as a Terraform output as it contains sensitive cluster credentials that could be logged or stored insecurely.

#ai-review-inline

Kubeconfig should not be exposed as a Terraform output as it contains sensitive cluster credentials that could be logged or stored insecurely. #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +2,4 @@
# NEVER commit aks.env to git!
# Required
AZURE_TENANT_ID=your-azure-tenant-id
Owner

Example file contains placeholder values that could be mistaken for real credentials.

AZURE_TENANT_ID=00000000-0000-0000-0000-000000000000

#ai-review-inline

Example file contains placeholder values that could be mistaken for real credentials. ```suggestion AZURE_TENANT_ID=00000000-0000-0000-0000-000000000000 ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +3,4 @@
# Required
AZURE_TENANT_ID=your-azure-tenant-id
AZURE_SUBSCRIPTION_ID=your-azure-subscription-id
Owner

Example file contains placeholder values that could be mistaken for real credentials.

AZURE_SUBSCRIPTION_ID=00000000-0000-0000-0000-000000000000

#ai-review-inline

Example file contains placeholder values that could be mistaken for real credentials. ```suggestion AZURE_SUBSCRIPTION_ID=00000000-0000-0000-0000-000000000000 ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +1,9 @@
# GCP GKE credentials — copy to gke.env and fill in values
# NEVER commit gke.env to git!
Owner

Remove empty line with trailing comment marker to clean up the example file format.

#ai-review-inline

Remove empty line with trailing comment marker to clean up the example file format. #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +4,4 @@
# Required
GCP_PROJECT_ID=your-gcp-project-id
GCP_REGION=europe-west4
Owner

Remove empty line with trailing comment marker to clean up the example file format.

#ai-review-inline

Remove empty line with trailing comment marker to clean up the example file format. #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +2,4 @@
# NEVER commit upc.env to git!
# Required
UPCLOUD_TOKEN=your-upcloud-api-token
Owner

Example credential files should use placeholder values that cannot be mistaken for real tokens.

UPCLOUD_TOKEN=upcloud-api-token-here

#ai-review-inline

Example credential files should use placeholder values that cannot be mistaken for real tokens. ```suggestion UPCLOUD_TOKEN=upcloud-api-token-here ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +2,4 @@
# NEVER commit aks.env to git!
# Required
AZURE_TENANT_ID=your-azure-tenant-id
Owner

Example file contains placeholder values that could be mistaken for real credentials.

AZURE_TENANT_ID=00000000-0000-0000-0000-000000000000

#ai-review-inline

Example file contains placeholder values that could be mistaken for real credentials. ```suggestion AZURE_TENANT_ID=00000000-0000-0000-0000-000000000000 ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +3,4 @@
# Required
AZURE_TENANT_ID=your-azure-tenant-id
AZURE_SUBSCRIPTION_ID=your-azure-subscription-id
Owner

Example file contains placeholder values that could be mistaken for real credentials.

AZURE_SUBSCRIPTION_ID=00000000-0000-0000-0000-000000000000

#ai-review-inline

Example file contains placeholder values that could be mistaken for real credentials. ```suggestion AZURE_SUBSCRIPTION_ID=00000000-0000-0000-0000-000000000000 ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +1,9 @@
# GCP GKE credentials — copy to gke.env and fill in values
# NEVER commit gke.env to git!
Owner

Remove empty line with trailing comment marker to clean up the example file format.

#ai-review-inline

Remove empty line with trailing comment marker to clean up the example file format. #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +4,4 @@
# Required
GCP_PROJECT_ID=your-gcp-project-id
GCP_REGION=europe-west4
Owner

Remove empty line with trailing comment marker to clean up the example file format.

#ai-review-inline

Remove empty line with trailing comment marker to clean up the example file format. #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +2,4 @@
# NEVER commit upc.env to git!
# Required
UPCLOUD_TOKEN=your-upcloud-api-token
Owner

Example credential files should use placeholder values that cannot be mistaken for real tokens.

UPCLOUD_TOKEN=upcloud-api-token-here

#ai-review-inline

Example credential files should use placeholder values that cannot be mistaken for real tokens. ```suggestion UPCLOUD_TOKEN=upcloud-api-token-here ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +6,4 @@
resource_group_name = "clst-dev-rg"
# AKS small dev nodes
aks_node_vm_size = "Standard_B2s"
Owner

Standard_B2s is a burstable instance type which may not provide consistent performance for AKS workloads.

aks_node_vm_size = "Standard_D2s_v3"

#ai-review-inline

Standard_B2s is a burstable instance type which may not provide consistent performance for AKS workloads. ```suggestion aks_node_vm_size = "Standard_D2s_v3" ``` #ai-review-inline
@@ -0,0 +7,4 @@
# AKS small dev nodes
aks_node_vm_size = "Standard_B2s"
aks_node_count = 2
Owner

Two nodes provides no redundancy; consider at least 3 nodes for high availability.

aks_node_count   = 3

#ai-review-inline

Two nodes provides no redundancy; consider at least 3 nodes for high availability. ```suggestion aks_node_count = 3 ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:07 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:09 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +27,4 @@
output "kubeconfig" {
description = "Kubeconfig for the AKS cluster"
value = azurerm_kubernetes_cluster.main.kube_config_raw
Owner

Exposing raw kubeconfig as output can lead to credential leakage in Terraform state and logs.

#ai-review-inline

Exposing raw kubeconfig as output can lead to credential leakage in Terraform state and logs. #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:10 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +7,4 @@
# AKS general-purpose nodes for production
aks_node_vm_size = "Standard_D4s_v3"
aks_node_count = 3
Owner

Production AKS cluster has only 3 nodes which may not provide sufficient availability for production workloads.

  aks_node_count   = 5

#ai-review-inline

Production AKS cluster has only 3 nodes which may not provide sufficient availability for production workloads. ```suggestion aks_node_count = 5 ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:10 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +4,4 @@
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "~> 4.0"
Owner

Use a more specific version constraint to ensure reproducible deployments and avoid potential breaking changes.

      version = "~> 4.8"

#ai-review-inline

Use a more specific version constraint to ensure reproducible deployments and avoid potential breaking changes. ```suggestion version = "~> 4.8" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:13 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +12,4 @@
node_count = 2
node_min_count = 1
node_max_count = 4
kubernetes_version = "1.30"
Owner

Kubernetes version should be pinned to a specific patch version for reproducibility and security patching control.

  kubernetes_version = "1.30.6"

#ai-review-inline

Kubernetes version should be pinned to a specific patch version for reproducibility and security patching control. ```suggestion kubernetes_version = "1.30.6" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:13 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +37,4 @@
# AKS Cluster
resource "azurerm_kubernetes_cluster" "main" {
Owner

AKS cluster lacks essential security configurations like private cluster mode and authorized IP ranges.

#ai-review-inline

AKS cluster lacks essential security configurations like private cluster mode and authorized IP ranges. #ai-review-inline
@@ -0,0 +45,4 @@
kubernetes_version = var.aks_kubernetes_version
tags = var.tags
default_node_pool {
Owner

Default node pool lacks resource limits (max_count) and auto-scaling, which can lead to unbounded resource consumption.

  default_node_pool {
    name            = "system"
    node_count      = var.aks_node_count
    min_count       = var.aks_node_count
    max_count       = var.aks_node_count * 3
    enable_auto_scaling = true
    vm_size         = var.aks_node_vm_size
    vnet_subnet_id  = azurerm_subnet.aks.id
    node_labels = {
      prefix = var.prefix
      role   = "worker"
      env    = lookup(var.tags, "Environment", "dev")
    }
  }

#ai-review-inline

Default node pool lacks resource limits (max_count) and auto-scaling, which can lead to unbounded resource consumption. ```suggestion default_node_pool { name = "system" node_count = var.aks_node_count min_count = var.aks_node_count max_count = var.aks_node_count * 3 enable_auto_scaling = true vm_size = var.aks_node_vm_size vnet_subnet_id = azurerm_subnet.aks.id node_labels = { prefix = var.prefix role = "worker" env = lookup(var.tags, "Environment", "dev") } } ``` #ai-review-inline
@@ -0,0 +61,4 @@
type = "SystemAssigned"
}
network_profile {
Owner

Network profile is missing pod_cidr and service_cidr configuration, which may cause IP allocation conflicts.

  network_profile {
    network_plugin    = "azure"
    network_policy    = "azure"
    service_cidr      = "10.0.0.0/16"
    dns_service_ip    = "10.0.0.10"
  }

#ai-review-inline

Network profile is missing pod_cidr and service_cidr configuration, which may cause IP allocation conflicts. ```suggestion network_profile { network_plugin = "azure" network_policy = "azure" service_cidr = "10.0.0.0/16" dns_service_ip = "10.0.0.10" } ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:13 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:13 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +6,4 @@
}
tls = {
source = "hashicorp/tls"
version = "~> 4.0"
Owner

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates.

      version = "~> 4.0.5"

#ai-review-inline

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates. ```suggestion version = "~> 4.0.5" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +6,4 @@
}
tls = {
source = "hashicorp/tls"
version = "~> 4.0"
Owner

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates.

      version = "~> 4.0.5"

#ai-review-inline

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates. ```suggestion version = "~> 4.0.5" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +18,4 @@
variable "vnet_address_space" {
description = "Address space for the virtual network"
type = string
default = "10.100.0.0/16"
Owner

Consider using a smaller default CIDR range to avoid potential IP conflicts with on-premises networks.

  default     = "10.240.0.0/16"

#ai-review-inline

Consider using a smaller default CIDR range to avoid potential IP conflicts with on-premises networks. ```suggestion default = "10.240.0.0/16" ``` #ai-review-inline
@@ -0,0 +24,4 @@
variable "aks_subnet_cidr" {
description = "CIDR block for the AKS node subnet"
type = string
default = "10.100.0.0/22"
Owner

Default subnet CIDR should align with the updated VNet address space if changed.

  default     = "10.240.0.0/22"

#ai-review-inline

Default subnet CIDR should align with the updated VNet address space if changed. ```suggestion default = "10.240.0.0/22" ``` #ai-review-inline
@@ -0,0 +30,4 @@
variable "aks_node_vm_size" {
description = "VM size for AKS worker nodes (e.g., Standard_B2s, Standard_D4s_v3)"
type = string
}
Owner

Consider adding validation to restrict to supported Azure VM sizes for better cost control and compatibility.

variable "aks_node_vm_size" {
  description = "VM size for AKS worker nodes (e.g., Standard_B2s, Standard_D4s_v3)"
  type        = string
  validation {
    condition = can(regex("^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*_v[0-9]+$|^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*$", var.aks_node_vm_size))
    error_message = "VM size must be a valid Azure VM size (e.g., Standard_B2s, Standard_D4s_v3)."
  }
}

#ai-review-inline

Consider adding validation to restrict to supported Azure VM sizes for better cost control and compatibility. ```suggestion variable "aks_node_vm_size" { description = "VM size for AKS worker nodes (e.g., Standard_B2s, Standard_D4s_v3)" type = string validation { condition = can(regex("^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*_v[0-9]+$|^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*$", var.aks_node_vm_size)) error_message = "VM size must be a valid Azure VM size (e.g., Standard_B2s, Standard_D4s_v3)." } } ``` #ai-review-inline
@@ -0,0 +35,4 @@
variable "aks_node_count" {
description = "Number of AKS worker nodes"
type = number
}
Owner

Consider adding validation to ensure node count is within reasonable bounds (1-100).

variable "aks_node_count" {
  description = "Number of AKS worker nodes"
  type        = number
  validation {
    condition     = var.aks_node_count >= 1 && var.aks_node_count <= 100
    error_message = "Node count must be between 1 and 100."
  }
}

#ai-review-inline

Consider adding validation to ensure node count is within reasonable bounds (1-100). ```suggestion variable "aks_node_count" { description = "Number of AKS worker nodes" type = number validation { condition = var.aks_node_count >= 1 && var.aks_node_count <= 100 error_message = "Node count must be between 1 and 100." } } ``` #ai-review-inline
@@ -0,0 +2,4 @@
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.0"
Owner

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates.

      version = "~> 5.70"

#ai-review-inline

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates. ```suggestion version = "~> 5.70" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +18,4 @@
variable "vnet_address_space" {
description = "Address space for the virtual network"
type = string
default = "10.100.0.0/16"
Owner

Consider using a smaller default CIDR range to avoid potential IP conflicts with on-premises networks.

  default     = "10.240.0.0/16"

#ai-review-inline

Consider using a smaller default CIDR range to avoid potential IP conflicts with on-premises networks. ```suggestion default = "10.240.0.0/16" ``` #ai-review-inline
@@ -0,0 +24,4 @@
variable "aks_subnet_cidr" {
description = "CIDR block for the AKS node subnet"
type = string
default = "10.100.0.0/22"
Owner

Default subnet CIDR should align with the updated VNet address space if changed.

  default     = "10.240.0.0/22"

#ai-review-inline

Default subnet CIDR should align with the updated VNet address space if changed. ```suggestion default = "10.240.0.0/22" ``` #ai-review-inline
@@ -0,0 +30,4 @@
variable "aks_node_vm_size" {
description = "VM size for AKS worker nodes (e.g., Standard_B2s, Standard_D4s_v3)"
type = string
}
Owner

Consider adding validation to restrict to supported Azure VM sizes for better cost control and compatibility.

variable "aks_node_vm_size" {
  description = "VM size for AKS worker nodes (e.g., Standard_B2s, Standard_D4s_v3)"
  type        = string
  validation {
    condition = can(regex("^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*_v[0-9]+$|^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*$", var.aks_node_vm_size))
    error_message = "VM size must be a valid Azure VM size (e.g., Standard_B2s, Standard_D4s_v3)."
  }
}

#ai-review-inline

Consider adding validation to restrict to supported Azure VM sizes for better cost control and compatibility. ```suggestion variable "aks_node_vm_size" { description = "VM size for AKS worker nodes (e.g., Standard_B2s, Standard_D4s_v3)" type = string validation { condition = can(regex("^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*_v[0-9]+$|^Standard_[BDEFGHKLMNPRS][0-9]+[a-z]*$", var.aks_node_vm_size)) error_message = "VM size must be a valid Azure VM size (e.g., Standard_B2s, Standard_D4s_v3)." } } ``` #ai-review-inline
@@ -0,0 +35,4 @@
variable "aks_node_count" {
description = "Number of AKS worker nodes"
type = number
}
Owner

Consider adding validation to ensure node count is within reasonable bounds (1-100).

variable "aks_node_count" {
  description = "Number of AKS worker nodes"
  type        = number
  validation {
    condition     = var.aks_node_count >= 1 && var.aks_node_count <= 100
    error_message = "Node count must be between 1 and 100."
  }
}

#ai-review-inline

Consider adding validation to ensure node count is within reasonable bounds (1-100). ```suggestion variable "aks_node_count" { description = "Number of AKS worker nodes" type = number validation { condition = var.aks_node_count >= 1 && var.aks_node_count <= 100 error_message = "Node count must be between 1 and 100." } } ``` #ai-review-inline
@@ -0,0 +2,4 @@
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.0"
Owner

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates.

      version = "~> 5.70"

#ai-review-inline

Consider using a more specific version constraint to ensure reproducible builds and avoid unexpected updates. ```suggestion version = "~> 5.70" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:16 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +12,4 @@
node_count = 3
node_min_count = 3
node_max_count = 6
kubernetes_version = "1.30"
Owner

Kubernetes version should be pinned to a specific patch version (e.g., '1.30.6') to ensure consistent deployments and avoid unexpected upgrades.

  kubernetes_version = "1.30.6"

#ai-review-inline

Kubernetes version should be pinned to a specific patch version (e.g., '1.30.6') to ensure consistent deployments and avoid unexpected upgrades. ```suggestion kubernetes_version = "1.30.6" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:17 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +47,4 @@
variable "aks_node_vm_size" {
description = "VM size for AKS worker nodes"
type = string
default = "Standard_B2s"
Owner

VM size Standard_B2s may be too small for production workloads and could cause resource constraints.

  default     = "Standard_D2s_v3"

#ai-review-inline

VM size Standard_B2s may be too small for production workloads and could cause resource constraints. ```suggestion default = "Standard_D2s_v3" ``` #ai-review-inline
@@ -0,0 +53,4 @@
variable "aks_node_count" {
description = "Number of AKS worker nodes"
type = number
default = 2
Owner

Node count of 2 provides no high availability; consider at least 3 nodes for production resilience.

  default     = 3

#ai-review-inline

Node count of 2 provides no high availability; consider at least 3 nodes for production resilience. ```suggestion default = 3 ``` #ai-review-inline
@@ -0,0 +64,4 @@
variable "domain" {
description = "Public domain name — must have an existing Azure DNS zone"
type = string
Owner

Domain variable lacks a default value and has no validation, which could cause deployment failures.

variable "domain" {
  description = "Public domain name — must have an existing Azure DNS zone"
  type        = string
  
  validation {
    condition     = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain))
    error_message = "Domain must be a valid FQDN."
  }
}

#ai-review-inline

Domain variable lacks a default value and has no validation, which could cause deployment failures. ```suggestion variable "domain" { description = "Public domain name — must have an existing Azure DNS zone" type = string validation { condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain)) error_message = "Domain must be a valid FQDN." } } ``` #ai-review-inline
@@ -0,0 +117,4 @@
kubernetes_version = var.aks_kubernetes_version
tags = var.tags
default_node_pool {
Owner

Default node pool is missing enable_auto_scaling and lacks resource limits which could cause node exhaustion.

  default_node_pool {
    name               = "system"
    node_count         = var.aks_node_count
    vm_size            = var.aks_node_vm_size
    vnet_subnet_id     = azurerm_subnet.aks.id
    enable_auto_scaling = true
    min_count          = 2
    max_count          = 5
    node_labels = {
      prefix = var.prefix
      role   = "worker"
      env    = lookup(var.tags, "Environment", "workload")
    }
  }

#ai-review-inline

Default node pool is missing enable_auto_scaling and lacks resource limits which could cause node exhaustion. ```suggestion default_node_pool { name = "system" node_count = var.aks_node_count vm_size = var.aks_node_vm_size vnet_subnet_id = azurerm_subnet.aks.id enable_auto_scaling = true min_count = 2 max_count = 5 node_labels = { prefix = var.prefix role = "worker" env = lookup(var.tags, "Environment", "workload") } } ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:17 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:17 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +47,4 @@
variable "aks_node_vm_size" {
description = "VM size for AKS worker nodes"
type = string
default = "Standard_B2s"
Owner

VM size Standard_B2s may be too small for production workloads and could cause resource constraints.

  default     = "Standard_D2s_v3"

#ai-review-inline

VM size Standard_B2s may be too small for production workloads and could cause resource constraints. ```suggestion default = "Standard_D2s_v3" ``` #ai-review-inline
@@ -0,0 +53,4 @@
variable "aks_node_count" {
description = "Number of AKS worker nodes"
type = number
default = 2
Owner

Node count of 2 provides no high availability; consider at least 3 nodes for production resilience.

  default     = 3

#ai-review-inline

Node count of 2 provides no high availability; consider at least 3 nodes for production resilience. ```suggestion default = 3 ``` #ai-review-inline
@@ -0,0 +64,4 @@
variable "domain" {
description = "Public domain name — must have an existing Azure DNS zone"
type = string
Owner

Domain variable lacks a default value and has no validation, which could cause deployment failures.

variable "domain" {
  description = "Public domain name — must have an existing Azure DNS zone"
  type        = string
  
  validation {
    condition     = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain))
    error_message = "Domain must be a valid FQDN."
  }
}

#ai-review-inline

Domain variable lacks a default value and has no validation, which could cause deployment failures. ```suggestion variable "domain" { description = "Public domain name — must have an existing Azure DNS zone" type = string validation { condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain)) error_message = "Domain must be a valid FQDN." } } ``` #ai-review-inline
@@ -0,0 +117,4 @@
kubernetes_version = var.aks_kubernetes_version
tags = var.tags
default_node_pool {
Owner

Default node pool is missing enable_auto_scaling and lacks resource limits which could cause node exhaustion.

  default_node_pool {
    name               = "system"
    node_count         = var.aks_node_count
    vm_size            = var.aks_node_vm_size
    vnet_subnet_id     = azurerm_subnet.aks.id
    enable_auto_scaling = true
    min_count          = 2
    max_count          = 5
    node_labels = {
      prefix = var.prefix
      role   = "worker"
      env    = lookup(var.tags, "Environment", "workload")
    }
  }

#ai-review-inline

Default node pool is missing enable_auto_scaling and lacks resource limits which could cause node exhaustion. ```suggestion default_node_pool { name = "system" node_count = var.aks_node_count vm_size = var.aks_node_vm_size vnet_subnet_id = azurerm_subnet.aks.id enable_auto_scaling = true min_count = 2 max_count = 5 node_labels = { prefix = var.prefix role = "worker" env = lookup(var.tags, "Environment", "workload") } } ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:17 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:18 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +43,4 @@
})
}
# NAT Gateway (single, in first public subnet use one per AZ for prod HA)
Owner

Using a single NAT Gateway creates a single point of failure; consider one NAT Gateway per AZ for production high availability.

#ai-review-inline

Using a single NAT Gateway creates a single point of failure; consider one NAT Gateway per AZ for production high availability. #ai-review-inline
@@ -0,0 +121,4 @@
vpc_config {
subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
endpoint_private_access = true
endpoint_public_access = true
Owner

Public API endpoint access should be restricted to specific CIDR blocks for security.

    endpoint_public_access  = true
    public_access_cidrs     = ["YOUR_OFFICE_IP/32"]

#ai-review-inline

Public API endpoint access should be restricted to specific CIDR blocks for security. ```suggestion endpoint_public_access = true public_access_cidrs = ["YOUR_OFFICE_IP/32"] ``` #ai-review-inline
@@ -0,0 +185,4 @@
node_role_arn = aws_iam_role.eks_nodes.arn
subnet_ids = aws_subnet.private[*].id
instance_types = [var.node_instance_type]
Owner

Node instance types should be configurable as a list to support multiple instance types for better availability and cost optimization.

  instance_types = var.node_instance_types

#ai-review-inline

Node instance types should be configurable as a list to support multiple instance types for better availability and cost optimization. ```suggestion instance_types = var.node_instance_types ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:18 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +43,4 @@
})
}
# NAT Gateway (single, in first public subnet use one per AZ for prod HA)
Owner

Using a single NAT Gateway creates a single point of failure; consider one NAT Gateway per AZ for production high availability.

#ai-review-inline

Using a single NAT Gateway creates a single point of failure; consider one NAT Gateway per AZ for production high availability. #ai-review-inline
@@ -0,0 +121,4 @@
vpc_config {
subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
endpoint_private_access = true
endpoint_public_access = true
Owner

Public API endpoint access should be restricted to specific CIDR blocks for security.

    endpoint_public_access  = true
    public_access_cidrs     = ["YOUR_OFFICE_IP/32"]

#ai-review-inline

Public API endpoint access should be restricted to specific CIDR blocks for security. ```suggestion endpoint_public_access = true public_access_cidrs = ["YOUR_OFFICE_IP/32"] ``` #ai-review-inline
@@ -0,0 +185,4 @@
node_role_arn = aws_iam_role.eks_nodes.arn
subnet_ids = aws_subnet.private[*].id
instance_types = [var.node_instance_type]
Owner

Node instance types should be configurable as a list to support multiple instance types for better availability and cost optimization.

  instance_types = var.node_instance_types

#ai-review-inline

Node instance types should be configurable as a list to support multiple instance types for better availability and cost optimization. ```suggestion instance_types = var.node_instance_types ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:18 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +43,4 @@
})
}
# NAT Gateway (single, in first public subnet use one per AZ for prod HA)
Owner

Using a single NAT Gateway creates a single point of failure; consider one NAT Gateway per AZ for production high availability.

#ai-review-inline

Using a single NAT Gateway creates a single point of failure; consider one NAT Gateway per AZ for production high availability. #ai-review-inline
@@ -0,0 +121,4 @@
vpc_config {
subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
endpoint_private_access = true
endpoint_public_access = true
Owner

Public API endpoint access should be restricted to specific CIDR blocks for security.

    endpoint_public_access  = true
    public_access_cidrs     = ["YOUR_OFFICE_IP/32"]

#ai-review-inline

Public API endpoint access should be restricted to specific CIDR blocks for security. ```suggestion endpoint_public_access = true public_access_cidrs = ["YOUR_OFFICE_IP/32"] ``` #ai-review-inline
@@ -0,0 +185,4 @@
node_role_arn = aws_iam_role.eks_nodes.arn
subnet_ids = aws_subnet.private[*].id
instance_types = [var.node_instance_type]
Owner

Node instance types should be configurable as a list to support multiple instance types for better availability and cost optimization.

  instance_types = var.node_instance_types

#ai-review-inline

Node instance types should be configurable as a list to support multiple instance types for better availability and cost optimization. ```suggestion instance_types = var.node_instance_types ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:18 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +194,4 @@
}
update_config {
max_unavailable = 1
Owner

Consider using max_unavailable_percentage instead of a fixed number for better scaling flexibility.

    max_unavailable_percentage = 25

#ai-review-inline

Consider using `max_unavailable_percentage` instead of a fixed number for better scaling flexibility. ```suggestion max_unavailable_percentage = 25 ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:18 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +8,4 @@
# GKE small dev nodes
node_machine_type = "e2-standard-2"
node_count = 2
deletion_protection = false
Owner

Deletion protection disabled in dev environment creates risk of accidental cluster deletion.

  deletion_protection = true

#ai-review-inline

Deletion protection disabled in dev environment creates risk of accidental cluster deletion. ```suggestion deletion_protection = true ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:19 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +2,4 @@
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.0"
Owner

Use exact version pinning instead of pessimistic version constraint for better reproducibility in production environments.

      version = "5.73.0"

#ai-review-inline

Use exact version pinning instead of pessimistic version constraint for better reproducibility in production environments. ```suggestion version = "5.73.0" ``` #ai-review-inline
@@ -0,0 +6,4 @@
}
tls = {
source = "hashicorp/tls"
version = "~> 4.0"
Owner

Use exact version pinning instead of pessimistic version constraint for better reproducibility in production environments.

      version = "4.0.6"

#ai-review-inline

Use exact version pinning instead of pessimistic version constraint for better reproducibility in production environments. ```suggestion version = "4.0.6" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:19 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:21 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +15,4 @@
}
variable "project_id" {
description = "GCP project ID for the dev environment"
Owner

Variable lacks validation to ensure it follows GCP project ID naming rules (6-30 chars, lowercase, numbers, hyphens).

variable "project_id" {
  description = "GCP project ID for the dev environment"
  type        = string
  validation {
    condition     = can(regex("^[a-z][a-z0-9-]{4,28}[a-z0-9]$", var.project_id))
    error_message = "Project ID must be 6-30 characters, start with lowercase letter, and contain only lowercase letters, numbers, and hyphens."
  }
}

#ai-review-inline

Variable lacks validation to ensure it follows GCP project ID naming rules (6-30 chars, lowercase, numbers, hyphens). ```suggestion variable "project_id" { description = "GCP project ID for the dev environment" type = string validation { condition = can(regex("^[a-z][a-z0-9-]{4,28}[a-z0-9]$", var.project_id)) error_message = "Project ID must be 6-30 characters, start with lowercase letter, and contain only lowercase letters, numbers, and hyphens." } } ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:21 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +8,4 @@
# GKE general-purpose nodes for production
node_machine_type = "e2-standard-4"
node_count = 3
deletion_protection = true
Owner

Consider enabling deletion protection for production clusters to prevent accidental deletion.

#ai-review-inline

Consider enabling deletion protection for production clusters to prevent accidental deletion. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +2,4 @@
required_providers {
google = {
source = "hashicorp/google"
version = "~> 6.0"
Owner

Consider pinning to a more specific version range to avoid potential breaking changes from minor version updates.

      version = "~> 6.11"

#ai-review-inline

Consider pinning to a more specific version range to avoid potential breaking changes from minor version updates. ```suggestion version = "~> 6.11" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +56,4 @@
# Required APIs
resource "google_project_service" "compute" {
project = var.project_id
Owner

Variable 'project_id' is referenced but not defined in this file.

#ai-review-inline

Variable 'project_id' is referenced but not defined in this file. #ai-review-inline
@@ -0,0 +93,4 @@
project = var.project_id
name = "${var.prefix}-subnet"
ip_cidr_range = "10.110.0.0/22"
region = var.region
Owner

Variable 'region' is referenced but not defined in this file.

#ai-review-inline

Variable 'region' is referenced but not defined in this file. #ai-review-inline
@@ -0,0 +183,4 @@
resource "google_project_iam_member" "external_dns_dns_admin" {
project = var.project_id
role = "roles/dns.admin"
Owner

The 'roles/dns.admin' role is overly permissive and grants broad DNS management access.

role    = "roles/dns.recordsOwner"

#ai-review-inline

The 'roles/dns.admin' role is overly permissive and grants broad DNS management access. ```suggestion role = "roles/dns.recordsOwner" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +56,4 @@
# Required APIs
resource "google_project_service" "compute" {
project = var.project_id
Owner

Variable 'project_id' is referenced but not defined in this file.

#ai-review-inline

Variable 'project_id' is referenced but not defined in this file. #ai-review-inline
@@ -0,0 +93,4 @@
project = var.project_id
name = "${var.prefix}-subnet"
ip_cidr_range = "10.110.0.0/22"
region = var.region
Owner

Variable 'region' is referenced but not defined in this file.

#ai-review-inline

Variable 'region' is referenced but not defined in this file. #ai-review-inline
@@ -0,0 +183,4 @@
resource "google_project_iam_member" "external_dns_dns_admin" {
project = var.project_id
role = "roles/dns.admin"
Owner

The 'roles/dns.admin' role is overly permissive and grants broad DNS management access.

role    = "roles/dns.recordsOwner"

#ai-review-inline

The 'roles/dns.admin' role is overly permissive and grants broad DNS management access. ```suggestion role = "roles/dns.recordsOwner" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +64,4 @@
variable "domain" {
description = "Public domain name — must have an existing Route53 hosted zone"
type = string
Owner

Missing validation for domain variable - should ensure it's a valid FQDN.

variable "domain" {
  description = "Public domain name — must have an existing Route53 hosted zone"
  type        = string
  validation {
    condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain))
    error_message = "Domain must be a valid FQDN (e.g., example.com)."
  }
}

#ai-review-inline

Missing validation for domain variable - should ensure it's a valid FQDN. ```suggestion variable "domain" { description = "Public domain name — must have an existing Route53 hosted zone" type = string validation { condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain)) error_message = "Domain must be a valid FQDN (e.g., example.com)." } } ``` #ai-review-inline
@@ -0,0 +195,4 @@
vpc_config {
subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
endpoint_private_access = true
Owner

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security.

  vpc_config {
    subnet_ids                 = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
    endpoint_private_access    = true
    endpoint_public_access     = true
    public_access_cidrs        = ["0.0.0.0/0"] # TODO: Restrict to specific CIDR blocks
  }

#ai-review-inline

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security. ```suggestion vpc_config { subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id) endpoint_private_access = true endpoint_public_access = true public_access_cidrs = ["0.0.0.0/0"] # TODO: Restrict to specific CIDR blocks } ``` #ai-review-inline
@@ -0,0 +257,4 @@
node_role_arn = aws_iam_role.eks_nodes.arn
subnet_ids = aws_subnet.private[*].id
instance_types = [var.node_instance_type]
Owner

Node group using only one instance type - consider adding a secondary type for better availability.

  instance_types = [var.node_instance_type, "t3.large"]

#ai-review-inline

Node group using only one instance type - consider adding a secondary type for better availability. ```suggestion instance_types = [var.node_instance_type, "t3.large"] ``` #ai-review-inline
@@ -0,0 +328,4 @@
statement {
effect = "Allow"
actions = ["route53:ListHostedZones", "route53:ListResourceRecordSets", "route53:ListTagsForResource"]
resources = ["*"]
Owner

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible.

#ai-review-inline

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +64,4 @@
variable "domain" {
description = "Public domain name — must have an existing Route53 hosted zone"
type = string
Owner

Missing validation for domain variable - should ensure it's a valid FQDN.

variable "domain" {
  description = "Public domain name — must have an existing Route53 hosted zone"
  type        = string
  validation {
    condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain))
    error_message = "Domain must be a valid FQDN (e.g., example.com)."
  }
}

#ai-review-inline

Missing validation for domain variable - should ensure it's a valid FQDN. ```suggestion variable "domain" { description = "Public domain name — must have an existing Route53 hosted zone" type = string validation { condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain)) error_message = "Domain must be a valid FQDN (e.g., example.com)." } } ``` #ai-review-inline
@@ -0,0 +195,4 @@
vpc_config {
subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
endpoint_private_access = true
Owner

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security.

  vpc_config {
    subnet_ids                 = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
    endpoint_private_access    = true
    endpoint_public_access     = true
    public_access_cidrs        = ["0.0.0.0/0"] # TODO: Restrict to specific CIDR blocks
  }

#ai-review-inline

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security. ```suggestion vpc_config { subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id) endpoint_private_access = true endpoint_public_access = true public_access_cidrs = ["0.0.0.0/0"] # TODO: Restrict to specific CIDR blocks } ``` #ai-review-inline
@@ -0,0 +257,4 @@
node_role_arn = aws_iam_role.eks_nodes.arn
subnet_ids = aws_subnet.private[*].id
instance_types = [var.node_instance_type]
Owner

Node group using only one instance type - consider adding a secondary type for better availability.

  instance_types = [var.node_instance_type, "t3.large"]

#ai-review-inline

Node group using only one instance type - consider adding a secondary type for better availability. ```suggestion instance_types = [var.node_instance_type, "t3.large"] ``` #ai-review-inline
@@ -0,0 +328,4 @@
statement {
effect = "Allow"
actions = ["route53:ListHostedZones", "route53:ListResourceRecordSets", "route53:ListTagsForResource"]
resources = ["*"]
Owner

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible.

#ai-review-inline

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:24 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +64,4 @@
variable "domain" {
description = "Public domain name — must have an existing Route53 hosted zone"
type = string
Owner

Missing validation for domain variable - should ensure it's a valid FQDN.

variable "domain" {
  description = "Public domain name — must have an existing Route53 hosted zone"
  type        = string
  validation {
    condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain))
    error_message = "Domain must be a valid FQDN (e.g., example.com)."
  }
}

#ai-review-inline

Missing validation for domain variable - should ensure it's a valid FQDN. ```suggestion variable "domain" { description = "Public domain name — must have an existing Route53 hosted zone" type = string validation { condition = can(regex("^[a-z0-9.-]+\\.[a-z]{2,}$", var.domain)) error_message = "Domain must be a valid FQDN (e.g., example.com)." } } ``` #ai-review-inline
@@ -0,0 +195,4 @@
vpc_config {
subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
endpoint_private_access = true
Owner

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security.

  vpc_config {
    subnet_ids                 = concat(aws_subnet.private[*].id, aws_subnet.public[*].id)
    endpoint_private_access    = true
    endpoint_public_access     = true
    public_access_cidrs        = ["0.0.0.0/0"] # TODO: Restrict to specific CIDR blocks
  }

#ai-review-inline

EKS endpoint_public_access enabled - consider restricting public access with public_access_cidrs for better security. ```suggestion vpc_config { subnet_ids = concat(aws_subnet.private[*].id, aws_subnet.public[*].id) endpoint_private_access = true endpoint_public_access = true public_access_cidrs = ["0.0.0.0/0"] # TODO: Restrict to specific CIDR blocks } ``` #ai-review-inline
@@ -0,0 +257,4 @@
node_role_arn = aws_iam_role.eks_nodes.arn
subnet_ids = aws_subnet.private[*].id
instance_types = [var.node_instance_type]
Owner

Node group using only one instance type - consider adding a secondary type for better availability.

  instance_types = [var.node_instance_type, "t3.large"]

#ai-review-inline

Node group using only one instance type - consider adding a secondary type for better availability. ```suggestion instance_types = [var.node_instance_type, "t3.large"] ``` #ai-review-inline
@@ -0,0 +328,4 @@
statement {
effect = "Allow"
actions = ["route53:ListHostedZones", "route53:ListResourceRecordSets", "route53:ListTagsForResource"]
resources = ["*"]
Owner

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible.

#ai-review-inline

Route53 IAM policy uses wildcard resource for list operations - consider scoping to specific hosted zones if possible. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:25 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "cluster_name"           { value = google_container_cluster.main.name } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "cluster_name" { value = google_container_cluster.main.name } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "project_id"             { value = var.project_id } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "project_id" { value = var.project_id } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
output "region" { value = var.region }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "region"                 { value = var.region } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "region" { value = var.region } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
output "region" { value = var.region }
output "external_dns_gsa_email" { value = google_service_account.external_dns.email }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "external_dns_gsa_email" { value = google_service_account.external_dns.email } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "external_dns_gsa_email" { value = google_service_account.external_dns.email } # added ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:25 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "cluster_name"           { value = google_container_cluster.main.name } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "cluster_name" { value = google_container_cluster.main.name } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "project_id"             { value = var.project_id } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "project_id" { value = var.project_id } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
output "region" { value = var.region }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "region"                 { value = var.region } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "region" { value = var.region } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
output "region" { value = var.region }
output "external_dns_gsa_email" { value = google_service_account.external_dns.email }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "external_dns_gsa_email" { value = google_service_account.external_dns.email } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "external_dns_gsa_email" { value = google_service_account.external_dns.email } # added ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:25 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "cluster_name"           { value = google_container_cluster.main.name } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "cluster_name" { value = google_container_cluster.main.name } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "project_id"             { value = var.project_id } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "project_id" { value = var.project_id } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
output "region" { value = var.region }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "region"                 { value = var.region } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "region" { value = var.region } # added ``` #ai-review-inline
@@ -0,0 +1,4 @@
output "cluster_name" { value = google_container_cluster.main.name }
output "project_id" { value = var.project_id }
output "region" { value = var.region }
output "external_dns_gsa_email" { value = google_service_account.external_dns.email }
Owner

Output value should be wrapped in quotes for consistency with Terraform string outputs.

output "external_dns_gsa_email" { value = google_service_account.external_dns.email } # added

#ai-review-inline

Output value should be wrapped in quotes for consistency with Terraform string outputs. ```suggestion output "external_dns_gsa_email" { value = google_service_account.external_dns.email } # added ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:25 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +10,4 @@
}
provider "upcloud" {
# Set via environment variables: UPCLOUD_USERNAME, UPCLOUD_PASSWORD
Owner

Provider authentication should reference environment variables explicitly or use a more secure method than username/password.

  # Authentication via environment variables:
  # UPCLOUD_USERNAME and UPCLOUD_PASSWORD
  # Consider using API tokens instead of username/password for better security

#ai-review-inline

Provider authentication should reference environment variables explicitly or use a more secure method than username/password. ```suggestion # Authentication via environment variables: # UPCLOUD_USERNAME and UPCLOUD_PASSWORD # Consider using API tokens instead of username/password for better security ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +25,4 @@
resource "google_compute_subnetwork" "main" {
project = var.project_id
name = "${var.prefix}-subnet"
ip_cidr_range = "10.100.0.0/22"
Owner

Hardcoded CIDR range should be configurable via variable to support different network architectures.

  ip_cidr_range = var.subnet_cidr

#ai-review-inline

Hardcoded CIDR range should be configurable via variable to support different network architectures. ```suggestion ip_cidr_range = var.subnet_cidr ``` #ai-review-inline
@@ -0,0 +32,4 @@
# Secondary ranges required for GKE VPC-native cluster
secondary_ip_range {
range_name = "pods"
ip_cidr_range = "10.200.0.0/14" # /14 = ~262k pod IPs
Owner

Hardcoded pod CIDR range should be configurable via variable for flexibility across environments.

    ip_cidr_range = var.pod_cidr

#ai-review-inline

Hardcoded pod CIDR range should be configurable via variable for flexibility across environments. ```suggestion ip_cidr_range = var.pod_cidr ``` #ai-review-inline
@@ -0,0 +37,4 @@
secondary_ip_range {
range_name = "services"
ip_cidr_range = "10.204.0.0/20" # /20 = ~4k service IPs
Owner

Hardcoded service CIDR range should be configurable via variable for flexibility across environments.

    ip_cidr_range = var.service_cidr

#ai-review-inline

Hardcoded service CIDR range should be configurable via variable for flexibility across environments. ```suggestion ip_cidr_range = var.service_cidr ``` #ai-review-inline
@@ -0,0 +91,4 @@
cluster = google_container_cluster.main.name
node_count = var.node_count
node_config {
Owner

Missing security hardening options like boot disk encryption and security group configuration.

  node_config {
    machine_type = var.node_machine_type
    
    disk_encryption = "ENCRYPTION_AT_REST"
    
    shielded_instance_config {
      enable_secure_boot          = true
      enable_integrity_monitoring = true
    }

#ai-review-inline

Missing security hardening options like boot disk encryption and security group configuration. ```suggestion node_config { machine_type = var.node_machine_type disk_encryption = "ENCRYPTION_AT_REST" shielded_instance_config { enable_secure_boot = true enable_integrity_monitoring = true } ``` #ai-review-inline
@@ -0,0 +100,4 @@
}
oauth_scopes = [
"https://www.googleapis.com/auth/cloud-platform",
Owner

OAuth scope 'cloud-platform' is overly broad and grants excessive permissions - use specific scopes instead.

      "https://www.googleapis.com/auth/logging.write",
      "https://www.googleapis.com/auth/monitoring",
      "https://www.googleapis.com/auth/devstorage.read_only",

#ai-review-inline

OAuth scope 'cloud-platform' is overly broad and grants excessive permissions - use specific scopes instead. ```suggestion "https://www.googleapis.com/auth/logging.write", "https://www.googleapis.com/auth/monitoring", "https://www.googleapis.com/auth/devstorage.read_only", ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +35,4 @@
name = "${var.prefix}-${var.cluster_name}"
zone = var.zone
network = upcloud_network.kubernetes.id
control_plane_ip_filter = var.control_plane_ip_filter
Owner

Consider making control plane IP filter more restrictive than default to limit management access.

#ai-review-inline

Consider making control plane IP filter more restrictive than default to limit management access. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:26 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +35,4 @@
name = "${var.prefix}-${var.cluster_name}"
zone = var.zone
network = upcloud_network.kubernetes.id
control_plane_ip_filter = var.control_plane_ip_filter
Owner

Consider making control plane IP filter more restrictive than default to limit management access.

#ai-review-inline

Consider making control plane IP filter more restrictive than default to limit management access. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:27 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +37,4 @@
network = upcloud_network.kubernetes.id
control_plane_ip_filter = var.control_plane_ip_filter
private_node_groups = true
Owner

Private node groups is a good security practice for isolating worker nodes from public internet.

#ai-review-inline

Private node groups is a good security practice for isolating worker nodes from public internet. #ai-review-inline
@@ -0,0 +35,4 @@
variable "control_plane_ip_filter" {
description = "CIDRs allowed to access the K8s API"
type = list(string)
default = ["0.0.0.0/0"]
Owner

Default control plane access allows all IPs (0.0.0.0/0), which exposes the Kubernetes API to the entire internet - this is a significant security risk.

  default     = []

#ai-review-inline

Default control plane access allows all IPs (0.0.0.0/0), which exposes the Kubernetes API to the entire internet - this is a significant security risk. ```suggestion default = [] ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:28 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +7,4 @@
node_count = 3
network_cidr = "10.100.0.0/24"
control_plane_ip_filter = ["0.0.0.0/0"] # TODO: restrict to known CIDRs
Owner

Control plane access is exposed to the entire internet (0.0.0.0/0), which is a critical security risk for production.

  control_plane_ip_filter = ["10.0.0.0/8", "172.16.0.0/12", "192.168.0.0/16"] # Restrict to private networks

#ai-review-inline

Control plane access is exposed to the entire internet (0.0.0.0/0), which is a critical security risk for production. ```suggestion control_plane_ip_filter = ["10.0.0.0/8", "172.16.0.0/12", "192.168.0.0/16"] # Restrict to private networks ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:29 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +10,4 @@
}
provider "upcloud" {
# Set via environment variables: UPCLOUD_USERNAME, UPCLOUD_PASSWORD
Owner

Authentication credentials should be explicitly documented or validated to ensure they're properly set via environment variables.

  # Authentication via environment variables: UPCLOUD_USERNAME and UPCLOUD_PASSWORD
  # Verify these are set in your CI/CD pipeline or local environment

#ai-review-inline

Authentication credentials should be explicitly documented or validated to ensure they're properly set via environment variables. ```suggestion # Authentication via environment variables: UPCLOUD_USERNAME and UPCLOUD_PASSWORD # Verify these are set in your CI/CD pipeline or local environment ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:29 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +47,4 @@
variable "control_plane_ip_filter" {
description = "CIDRs allowed to access the K8s API"
type = list(string)
default = ["0.0.0.0/0"]
Owner

Control plane API is exposed to the entire internet with 0.0.0.0/0 CIDR which creates a security risk.

default     = ["10.0.0.0/8", "192.168.0.0/16", "172.16.0.0/12"]

#ai-review-inline

Control plane API is exposed to the entire internet with 0.0.0.0/0 CIDR which creates a security risk. ```suggestion default = ["10.0.0.0/8", "192.168.0.0/16", "172.16.0.0/12"] ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:29 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +10,4 @@
}
provider "upcloud" {
# Set via environment variables: UPCLOUD_USERNAME, UPCLOUD_PASSWORD
Owner

Document the required environment variables in a README or use Terraform variables with descriptions instead of relying solely on comments.

#ai-review-inline

Document the required environment variables in a README or use Terraform variables with descriptions instead of relying solely on comments. #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:30 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +4,4 @@
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
# Delegate to setup-cluster.sh with --destroy flag
exec "$SCRIPT_DIR/setup-cluster.sh" "$@" --destroy
Owner

Using exec with user-provided arguments ($@) before --destroy creates a command injection risk if malicious arguments are passed.

exec "$SCRIPT_DIR/setup-cluster.sh" --destroy "$@"

#ai-review-inline

Using exec with user-provided arguments ($@) before --destroy creates a command injection risk if malicious arguments are passed. ```suggestion exec "$SCRIPT_DIR/setup-cluster.sh" --destroy "$@" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:34 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +30,4 @@
case "$PLATFORM" in
aks)
cd "$TOFU_DIR"
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "$CLUSTER-rg")
Owner

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values.

RG=$(tofu output -raw resource_group_name 2>/dev/null) || RG="$CLUSTER-rg"

#ai-review-inline

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null) || RG="$CLUSTER-rg" ``` #ai-review-inline
@@ -0,0 +36,4 @@
;;
eks)
cd "$TOFU_DIR"
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "$CLUSTER")
Owner

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values.

NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER"

#ai-review-inline

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER" ``` #ai-review-inline
@@ -0,0 +42,4 @@
;;
gke)
cd "$TOFU_DIR"
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "$CLUSTER")
Owner

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values.

NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER"

#ai-review-inline

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER" ``` #ai-review-inline
@@ -0,0 +44,4 @@
cd "$TOFU_DIR"
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "$CLUSTER")
REGION=$(tofu output -raw region 2>/dev/null || echo "${GCP_REGION:-europe-west4}")
PROJECT=$(tofu output -raw project_id 2>/dev/null || echo "${GCP_PROJECT_ID:-}")
Owner

Missing validation for required GCP_PROJECT_ID variable; script could fail with empty project ID.

PROJECT=$(tofu output -raw project_id 2>/dev/null) || PROJECT="${GCP_PROJECT_ID:?GCP_PROJECT_ID environment variable is required}"

#ai-review-inline

Missing validation for required GCP_PROJECT_ID variable; script could fail with empty project ID. ```suggestion PROJECT=$(tofu output -raw project_id 2>/dev/null) || PROJECT="${GCP_PROJECT_ID:?GCP_PROJECT_ID environment variable is required}" ``` #ai-review-inline
@@ -0,0 +50,4 @@
;;
upc)
cd "$TOFU_DIR"
CLUSTER_ID=$(tofu output -raw cluster_id 2>/dev/null || echo "${UPCLOUD_CLUSTER_ID:-}")
Owner

Missing validation for required UPCLOUD_CLUSTER_ID variable; script could fail with empty cluster ID.

CLUSTER_ID=$(tofu output -raw cluster_id 2>/dev/null) || CLUSTER_ID="${UPCLOUD_CLUSTER_ID:?UPCLOUD_CLUSTER_ID environment variable is required}"

#ai-review-inline

Missing validation for required UPCLOUD_CLUSTER_ID variable; script could fail with empty cluster ID. ```suggestion CLUSTER_ID=$(tofu output -raw cluster_id 2>/dev/null) || CLUSTER_ID="${UPCLOUD_CLUSTER_ID:?UPCLOUD_CLUSTER_ID environment variable is required}" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:34 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:34 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:34 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +30,4 @@
case "$PLATFORM" in
aks)
cd "$TOFU_DIR"
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "$CLUSTER-rg")
Owner

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values.

RG=$(tofu output -raw resource_group_name 2>/dev/null) || RG="$CLUSTER-rg"

#ai-review-inline

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null) || RG="$CLUSTER-rg" ``` #ai-review-inline
@@ -0,0 +36,4 @@
;;
eks)
cd "$TOFU_DIR"
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "$CLUSTER")
Owner

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values.

NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER"

#ai-review-inline

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER" ``` #ai-review-inline
@@ -0,0 +42,4 @@
;;
gke)
cd "$TOFU_DIR"
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "$CLUSTER")
Owner

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values.

NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER"

#ai-review-inline

Command substitution with 'tofu output' could fail silently; add error handling or validation for the fallback values. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null) || NAME="$CLUSTER" ``` #ai-review-inline
@@ -0,0 +44,4 @@
cd "$TOFU_DIR"
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "$CLUSTER")
REGION=$(tofu output -raw region 2>/dev/null || echo "${GCP_REGION:-europe-west4}")
PROJECT=$(tofu output -raw project_id 2>/dev/null || echo "${GCP_PROJECT_ID:-}")
Owner

Missing validation for required GCP_PROJECT_ID variable; script could fail with empty project ID.

PROJECT=$(tofu output -raw project_id 2>/dev/null) || PROJECT="${GCP_PROJECT_ID:?GCP_PROJECT_ID environment variable is required}"

#ai-review-inline

Missing validation for required GCP_PROJECT_ID variable; script could fail with empty project ID. ```suggestion PROJECT=$(tofu output -raw project_id 2>/dev/null) || PROJECT="${GCP_PROJECT_ID:?GCP_PROJECT_ID environment variable is required}" ``` #ai-review-inline
@@ -0,0 +50,4 @@
;;
upc)
cd "$TOFU_DIR"
CLUSTER_ID=$(tofu output -raw cluster_id 2>/dev/null || echo "${UPCLOUD_CLUSTER_ID:-}")
Owner

Missing validation for required UPCLOUD_CLUSTER_ID variable; script could fail with empty cluster ID.

CLUSTER_ID=$(tofu output -raw cluster_id 2>/dev/null) || CLUSTER_ID="${UPCLOUD_CLUSTER_ID:?UPCLOUD_CLUSTER_ID environment variable is required}"

#ai-review-inline

Missing validation for required UPCLOUD_CLUSTER_ID variable; script could fail with empty cluster ID. ```suggestion CLUSTER_ID=$(tofu output -raw cluster_id 2>/dev/null) || CLUSTER_ID="${UPCLOUD_CLUSTER_ID:?UPCLOUD_CLUSTER_ID environment variable is required}" ``` #ai-review-inline
gitea_admin reviewed 2026-04-28 06:52:34 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
gitea_admin reviewed 2026-04-28 06:52:36 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +118,4 @@
if [[ -f "$CLUSTER_CONFIG" ]]; then
echo " Loading cluster config from clusters/$CLUSTER.yaml"
if command -v yq >/dev/null 2>&1; then
eval "$(yq -r 'to_entries[] | "export CLUSTER_\(.key)=\"\(.value)\""' "$CLUSTER_CONFIG")"
Owner

Potential command injection vulnerability when using yq with user-controlled cluster config.

    # Parse cluster config safely
    if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then
      CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG")
      export CLUSTER_clusterName="$CLUSTER_NAME"
      echo "  Cluster name: $CLUSTER_NAME"
    fi

#ai-review-inline

Potential command injection vulnerability when using yq with user-controlled cluster config. ```suggestion # Parse cluster config safely if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG") export CLUSTER_clusterName="$CLUSTER_NAME" echo " Cluster name: $CLUSTER_NAME" fi ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +184,4 @@
echo " Saved from tofu output"
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
Owner

Unquoted variable substitution could lead to command injection if cluster name contains special characters.

        RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")

#ai-review-inline

Unquoted variable substitution could lead to command injection if cluster name contains special characters. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +185,4 @@
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

        NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +190,4 @@
fi
;;
eks)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +195,4 @@
aws eks update-kubeconfig --name "$NAME" --region "$REGION" --kubeconfig "$KUBECONFIG_FILE"
;;
gke)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:37 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +118,4 @@
if [[ -f "$CLUSTER_CONFIG" ]]; then
echo " Loading cluster config from clusters/$CLUSTER.yaml"
if command -v yq >/dev/null 2>&1; then
eval "$(yq -r 'to_entries[] | "export CLUSTER_\(.key)=\"\(.value)\""' "$CLUSTER_CONFIG")"
Owner

Potential command injection vulnerability when using yq with user-controlled cluster config.

    # Parse cluster config safely
    if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then
      CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG")
      export CLUSTER_clusterName="$CLUSTER_NAME"
      echo "  Cluster name: $CLUSTER_NAME"
    fi

#ai-review-inline

Potential command injection vulnerability when using yq with user-controlled cluster config. ```suggestion # Parse cluster config safely if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG") export CLUSTER_clusterName="$CLUSTER_NAME" echo " Cluster name: $CLUSTER_NAME" fi ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +184,4 @@
echo " Saved from tofu output"
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
Owner

Unquoted variable substitution could lead to command injection if cluster name contains special characters.

        RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")

#ai-review-inline

Unquoted variable substitution could lead to command injection if cluster name contains special characters. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +185,4 @@
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

        NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +190,4 @@
fi
;;
eks)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +195,4 @@
aws eks update-kubeconfig --name "$NAME" --region "$REGION" --kubeconfig "$KUBECONFIG_FILE"
;;
gke)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:37 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +118,4 @@
if [[ -f "$CLUSTER_CONFIG" ]]; then
echo " Loading cluster config from clusters/$CLUSTER.yaml"
if command -v yq >/dev/null 2>&1; then
eval "$(yq -r 'to_entries[] | "export CLUSTER_\(.key)=\"\(.value)\""' "$CLUSTER_CONFIG")"
Owner

Potential command injection vulnerability when using yq with user-controlled cluster config.

    # Parse cluster config safely
    if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then
      CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG")
      export CLUSTER_clusterName="$CLUSTER_NAME"
      echo "  Cluster name: $CLUSTER_NAME"
    fi

#ai-review-inline

Potential command injection vulnerability when using yq with user-controlled cluster config. ```suggestion # Parse cluster config safely if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG") export CLUSTER_clusterName="$CLUSTER_NAME" echo " Cluster name: $CLUSTER_NAME" fi ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +184,4 @@
echo " Saved from tofu output"
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
Owner

Unquoted variable substitution could lead to command injection if cluster name contains special characters.

        RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")

#ai-review-inline

Unquoted variable substitution could lead to command injection if cluster name contains special characters. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +185,4 @@
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

        NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +190,4 @@
fi
;;
eks)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +195,4 @@
aws eks update-kubeconfig --name "$NAME" --region "$REGION" --kubeconfig "$KUBECONFIG_FILE"
;;
gke)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:37 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +118,4 @@
if [[ -f "$CLUSTER_CONFIG" ]]; then
echo " Loading cluster config from clusters/$CLUSTER.yaml"
if command -v yq >/dev/null 2>&1; then
eval "$(yq -r 'to_entries[] | "export CLUSTER_\(.key)=\"\(.value)\""' "$CLUSTER_CONFIG")"
Owner

Potential command injection vulnerability when using yq with user-controlled cluster config.

    # Parse cluster config safely
    if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then
      CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG")
      export CLUSTER_clusterName="$CLUSTER_NAME"
      echo "  Cluster name: $CLUSTER_NAME"
    fi

#ai-review-inline

Potential command injection vulnerability when using yq with user-controlled cluster config. ```suggestion # Parse cluster config safely if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG") export CLUSTER_clusterName="$CLUSTER_NAME" echo " Cluster name: $CLUSTER_NAME" fi ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +184,4 @@
echo " Saved from tofu output"
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
Owner

Unquoted variable substitution could lead to command injection if cluster name contains special characters.

        RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")

#ai-review-inline

Unquoted variable substitution could lead to command injection if cluster name contains special characters. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +185,4 @@
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

        NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +190,4 @@
fi
;;
eks)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +195,4 @@
aws eks update-kubeconfig --name "$NAME" --region "$REGION" --kubeconfig "$KUBECONFIG_FILE"
;;
gke)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
gitea_admin reviewed 2026-04-28 06:52:37 +00:00
gitea_admin left a comment
Owner

Inline review

Inline review
@@ -0,0 +118,4 @@
if [[ -f "$CLUSTER_CONFIG" ]]; then
echo " Loading cluster config from clusters/$CLUSTER.yaml"
if command -v yq >/dev/null 2>&1; then
eval "$(yq -r 'to_entries[] | "export CLUSTER_\(.key)=\"\(.value)\""' "$CLUSTER_CONFIG")"
Owner

Potential command injection vulnerability when using yq with user-controlled cluster config.

    # Parse cluster config safely
    if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then
      CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG")
      export CLUSTER_clusterName="$CLUSTER_NAME"
      echo "  Cluster name: $CLUSTER_NAME"
    fi

#ai-review-inline

Potential command injection vulnerability when using yq with user-controlled cluster config. ```suggestion # Parse cluster config safely if yq -e '.clusterName' "$CLUSTER_CONFIG" >/dev/null 2>&1; then CLUSTER_NAME=$(yq -r '.clusterName' "$CLUSTER_CONFIG") export CLUSTER_clusterName="$CLUSTER_NAME" echo " Cluster name: $CLUSTER_NAME" fi ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +184,4 @@
echo " Saved from tofu output"
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
Owner

Unquoted variable substitution could lead to command injection if cluster name contains special characters.

        RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")

#ai-review-inline

Unquoted variable substitution could lead to command injection if cluster name contains special characters. ```suggestion RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +185,4 @@
else
echo " Fetching from Azure CLI..."
RG=$(tofu output -raw resource_group_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}-rg")
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

        NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +190,4 @@
fi
;;
eks)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
@@ -0,0 +195,4 @@
aws eks update-kubeconfig --name "$NAME" --region "$REGION" --kubeconfig "$KUBECONFIG_FILE"
;;
gke)
NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")
Owner

Unquoted variable substitution could lead to command injection.

      NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}")

#ai-review-inline

Unquoted variable substitution could lead to command injection. ```suggestion NAME=$(tofu output -raw cluster_name 2>/dev/null || echo "${CLUSTER_clusterName:-$CLUSTER}") ``` #ai-review-inline
Ghost marked this conversation as resolved
Owner

This PR adds extensive OpenTofu infrastructure provisioning capabilities to the Kubernetes GitOps platform, introducing multi-cloud cluster provisioning automation.

What changed: Added comprehensive OpenTofu infrastructure-as-code modules and scripts for provisioning Kubernetes clusters across Azure AKS, AWS EKS, GCP GKE, and UpCloud platforms.

Affected services/namespaces: No direct Kubernetes namespace changes - this adds infrastructure provisioning layer that creates clusters where GitOps applications will be deployed. The infrastructure provisions clusters that will host namespaces like argocd, external-dns, cert-manager, etc.

Infrastructure impact: Major infrastructure addition - introduces automated cluster provisioning with configurable node counts, VM sizes, networking (VPCs/VNets with subnets), and resource scaling. AKS dev uses 2x Standard_B2s nodes, prod uses 3x Standard_D4s_v3 nodes. EKS dev uses 2x t3.medium, prod 3x m5.xlarge with auto-scaling 1-4/3-6 nodes. Includes workload identity/IRSA configurations for cloud-native authentication.

Security notes: Contains cloud provider credential configurations in git-ignored .env files, implements workload identity for keyless service access (Azure managed identity, AWS IRSA, GCP workload identity), and includes RBAC roles for external-dns DNS management. The credential handling requires extra review attention - ensure .env files remain git-ignored and follow least-privilege principles for cloud service account permissions.

#ai-review-summary

This PR adds extensive OpenTofu infrastructure provisioning capabilities to the Kubernetes GitOps platform, introducing multi-cloud cluster provisioning automation. **What changed**: Added comprehensive OpenTofu infrastructure-as-code modules and scripts for provisioning Kubernetes clusters across Azure AKS, AWS EKS, GCP GKE, and UpCloud platforms. **Affected services/namespaces**: No direct Kubernetes namespace changes - this adds infrastructure provisioning layer that creates clusters where GitOps applications will be deployed. The infrastructure provisions clusters that will host namespaces like argocd, external-dns, cert-manager, etc. **Infrastructure impact**: Major infrastructure addition - introduces automated cluster provisioning with configurable node counts, VM sizes, networking (VPCs/VNets with subnets), and resource scaling. AKS dev uses 2x Standard_B2s nodes, prod uses 3x Standard_D4s_v3 nodes. EKS dev uses 2x t3.medium, prod 3x m5.xlarge with auto-scaling 1-4/3-6 nodes. Includes workload identity/IRSA configurations for cloud-native authentication. **Security notes**: Contains cloud provider credential configurations in git-ignored .env files, implements workload identity for keyless service access (Azure managed identity, AWS IRSA, GCP workload identity), and includes RBAC roles for external-dns DNS management. The credential handling requires extra review attention - ensure .env files remain git-ignored and follow least-privilege principles for cloud service account permissions. #ai-review-summary
Ghost requested review from thomas.solbjor 2026-04-28 09:42:45 +00:00
gitea_admin added 1 commit 2026-04-28 11:28:15 +00:00
ignore
All checks were successful
AI Code Review / ai-review (pull_request) Successful in 6s
630b086295
gitea_admin added 1 commit 2026-05-29 15:46:37 +00:00
shared
All checks were successful
AI Code Review / ai-review (pull_request) Successful in 6s
28979b6e60
gitea_admin added 1 commit 2026-05-29 15:47:14 +00:00
Merge branch 'main' of https://git.forteapps.net/Forte/launchpad into feature/tofu
All checks were successful
AI Code Review / ai-review (pull_request) Successful in 7s
5a83c01af4
danijel.simeunovic changed title from WIP: feature/tofu to feature/tofu 2026-05-29 15:47:48 +00:00
danijel.simeunovic approved these changes 2026-05-29 15:48:16 +00:00
danijel.simeunovic merged commit a9dbaf5354 into main 2026-05-29 15:48:29 +00:00
danijel.simeunovic deleted branch feature/tofu 2026-05-29 15:48:29 +00:00
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Forte/launchpad#15